• CookieOfFortune@lemmy.world
      link
      fedilink
      arrow-up
      39
      ·
      1 year ago

      That just sounds to me like he hasn’t worked on large code bases with multiple teams. No way it would be considered acceptable once you’re interesting with enough other people.

      • masterspace@lemmy.ca
        link
        fedilink
        English
        arrow-up
        3
        ·
        edit-2
        1 year ago

        Or just worked on codebases long enough to forget them… the biggest bastard I’ve encountered has been past me

    • markstos@lemmy.world
      link
      fedilink
      English
      arrow-up
      32
      ·
      1 year ago

      Solution: Code Style Guidelines doc that the team agrees on. A checkbox in the PR template that affirms that code is compliant with the guidelines.

      This way it’s not personal, it’s a rule that everyone should follow as a shared standard.

    • SokathHisEyesOpen@lemmy.ml
      link
      fedilink
      English
      arrow-up
      6
      ·
      1 year ago

      I found a variable named “t” Friday. I figured I must be looking at the minified version, but nope! Someone just decided to name something “t”, I have no idea why.